johanels/rclone
1
0
Fork 0
mirror of https://github.com/rclone/rclone.git synced 2025-12-12 06:24:14 +01:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

bisync: skip TestBisyncConcurrent on non-local

Browse Source 
See discussion on
https://github.com/rclone/rclone/pull/8708#discussion_r2280308808
This commit is contained in:
nielash
2025-08-17 03:15:37 -04:00
parent 4c5764204d
commit e5fe0b1476
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/bisync/bisync_test.go
View File

@@ -281,6 +281,9 @@ func TestBisyncRemoteRemote(t *testing.T) {
// make sure rc can cope with running concurrent jobs // make sure rc can cope with running concurrent jobs
func TestBisyncConcurrent(t *testing.T) { func TestBisyncConcurrent(t *testing.T) {
if !isLocal(*fstest.RemoteName) {
t.Skip("TestBisyncConcurrent is skipped on non-local")
}
oldArgTestCase := argTestCase oldArgTestCase := argTestCase
*argTestCase = "basic" *argTestCase = "basic"
*ignoreLogs = true // not useful to compare logs here because both runs will be logging at once *ignoreLogs = true // not useful to compare logs here because both runs will be logging at once
@@ -596,11 +599,15 @@ func (b *bisyncTest) runTestCase(ctx context.Context, t *testing.T, testCase str
} }
} }
func isLocal(remote string) bool {
return bilib.IsLocalPath(remote) && !strings.HasPrefix(remote, ":") && !strings.Contains(remote, ",")
}
// makeTempRemote creates temporary folder and makes a filesystem // makeTempRemote creates temporary folder and makes a filesystem
// if a local path is provided, it's ignored (the test will run under system temp) // if a local path is provided, it's ignored (the test will run under system temp)
func (b *bisyncTest) makeTempRemote(ctx context.Context, remote, subdir string) (f, parent fs.Fs, path, canon string) { func (b *bisyncTest) makeTempRemote(ctx context.Context, remote, subdir string) (f, parent fs.Fs, path, canon string) {
var err error var err error
if bilib.IsLocalPath(remote) && !strings.HasPrefix(remote, ":") && !strings.Contains(remote, ",") { if isLocal(remote) {
if remote != "" && !strings.HasPrefix(remote, "local") && *fstest.RemoteName != "" { if remote != "" && !strings.HasPrefix(remote, "local") && *fstest.RemoteName != "" {
b.t.Fatalf(`Missing ":" in remote %q. Use "local" to test with local filesystem.`, remote) b.t.Fatalf(`Missing ":" in remote %q. Use "local" to test with local filesystem.`, remote)
} }