mirror of
https://github.com/rclone/rclone.git
synced 2025-12-11 22:14:05 +01:00
fs: remove unnecessary Seek call on log file
Some checks failed
build / windows (push) Has been cancelled
build / other_os (push) Has been cancelled
build / mac_amd64 (push) Has been cancelled
build / mac_arm64 (push) Has been cancelled
build / linux (push) Has been cancelled
build / go1.24 (push) Has been cancelled
build / linux_386 (push) Has been cancelled
build / lint (push) Has been cancelled
build / android-all (push) Has been cancelled
Build & Push Docker Images / Build Docker Image for linux/386 (push) Has been cancelled
Build & Push Docker Images / Build Docker Image for linux/amd64 (push) Has been cancelled
Build & Push Docker Images / Build Docker Image for linux/arm/v6 (push) Has been cancelled
Build & Push Docker Images / Build Docker Image for linux/arm/v7 (push) Has been cancelled
Build & Push Docker Images / Build Docker Image for linux/arm64 (push) Has been cancelled
Build & Push Docker Images / Merge & Push Final Docker Image (push) Has been cancelled
Some checks failed
build / windows (push) Has been cancelled
build / other_os (push) Has been cancelled
build / mac_amd64 (push) Has been cancelled
build / mac_arm64 (push) Has been cancelled
build / linux (push) Has been cancelled
build / go1.24 (push) Has been cancelled
build / linux_386 (push) Has been cancelled
build / lint (push) Has been cancelled
build / android-all (push) Has been cancelled
Build & Push Docker Images / Build Docker Image for linux/386 (push) Has been cancelled
Build & Push Docker Images / Build Docker Image for linux/amd64 (push) Has been cancelled
Build & Push Docker Images / Build Docker Image for linux/arm/v6 (push) Has been cancelled
Build & Push Docker Images / Build Docker Image for linux/arm/v7 (push) Has been cancelled
Build & Push Docker Images / Build Docker Image for linux/arm64 (push) Has been cancelled
Build & Push Docker Images / Merge & Push Final Docker Image (push) Has been cancelled
We were seeing a (non-fatal) error in our logs: ``` Failed to seek log file to end: seek /proc/1/fd/1: illegal seek ``` Because we open the log file with O_APPEND, we don't need to manually seek to the end. As https://pkg.go.dev/os#File.Seek also confirms that the behavior of `Seek` is not specified if the file has been opened with O_APPEND, remove the `Seek` call.
This commit is contained in:
committed by
Nick Craig-Wood
parent
f28c83c6de
commit
70d2fe6568
@@ -216,10 +216,6 @@ func InitLogging() {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
fs.Fatalf(nil, "Failed to open log file: %v", err)
|
fs.Fatalf(nil, "Failed to open log file: %v", err)
|
||||||
}
|
}
|
||||||
_, err = f.Seek(0, io.SeekEnd)
|
|
||||||
if err != nil {
|
|
||||||
fs.Errorf(nil, "Failed to seek log file to end: %v", err)
|
|
||||||
}
|
|
||||||
redirectStderr(f)
|
redirectStderr(f)
|
||||||
w = f
|
w = f
|
||||||
} else {
|
} else {
|
||||||
|
|||||||
Reference in New Issue
Block a user