refactor: replace strings.Replace with strings.ReplaceAll

strings.ReplaceAll(s, old, new) is a wrapper function for
strings.Replace(s, old, new, -1). But strings.ReplaceAll is more
readable and removes the hardcoded -1.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
Eng Zer Jun
2022-05-17 00:11:45 +08:00
committed by Nick Craig-Wood
parent b929a56f46
commit 4f0ddb60e7
20 changed files with 32 additions and 32 deletions

View File

@@ -317,7 +317,7 @@ func (r *Run) RemoveTestBinary() {
func (r *Run) Name() string {
ns := []string{
r.Backend,
strings.Replace(r.Path, "/", ".", -1),
strings.ReplaceAll(r.Path, "/", "."),
r.Remote,
}
if r.FastList {
@@ -325,7 +325,7 @@ func (r *Run) Name() string {
}
ns = append(ns, fmt.Sprintf("%d", r.Try))
s := strings.Join(ns, "-")
s = strings.Replace(s, ":", "", -1)
s = strings.ReplaceAll(s, ":", "")
return s
}