johanels/rclone
1
0
Fork 0
mirror of https://github.com/rclone/rclone.git synced 2025-12-11 22:14:05 +01:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

systemd: prevent unmount rc command from sending a STOPPING=1 sd-notify message

Browse Source 
This prevents an `rclone rcd` server from prematurely going into the
'deactivating' state, which was causing systemd to kill it with a
SIGABRT after the stop timeout.

Fixes #7540
This commit is contained in:
AThePeanut4
2024-07-15 22:41:51 +02:00
committed by Nick Craig-Wood
parent 4824837eed
commit 14629c66f9
2 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/systemd/notify.go
View File

@@ -9,10 +9,13 @@ import (
"github.com/rclone/rclone/lib/atexit"
)
// Notify systemd that the service is starting. This returns a
// Notify systemd that the service is ready. This returns a
// function which should be called to notify that the service is
// stopping. This function will be called on exit if the service exits
// on a signal.
// NOTE: this function should only be called once, and so it
// should generally only be used directly in a command's Run handler.
// It should not be called as a result of rc commands. See #7540.
func Notify() func() {
if _, err := daemon.SdNotify(false, daemon.SdNotifyReady); err != nil {
log.Printf("failed to notify ready to systemd: %v", err)