johanels/photoprism
1
0
Fork 0
mirror of https://github.com/photoprism/photoprism.git synced 2025-12-12 00:34:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

CI: Apply Go linter recommendations to "internal/commands" package #5330

Browse Source 
Signed-off-by: Michael Mayer <michael@photoprism.app>
This commit is contained in:
Michael Mayer
2025-11-22 17:55:26 +01:00
parent 0e6328a33d
commit 699ad5b50c
38 changed files with 79 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
internal/commands/download_format_test.go
View File

@@ -25,7 +25,7 @@ func createArgsLoggingYtDlp(t *testing.T) string {
b.WriteString(" if \"%%~A\"==\"--version\" ( echo 2025.09.23 & goto :eof )\r\n")
b.WriteString(" if \"%%~A\"==\"--dump-single-json\" ( echo {\"id\":\"abc\",\"title\":\"Test\",\"url\":\"http://example.com\",\"_type\":\"video\"} & goto :eof )\r\n")
b.WriteString(")\r\n")
if err := os.WriteFile(path, []byte(b.String()), 0o755); err != nil {
if err := os.WriteFile(path, []byte(b.String()), 0o600); err != nil {
t.Fatalf("failed to write fake yt-dlp: %v", err)
}
return path
@@ -44,7 +44,7 @@ func createArgsLoggingYtDlp(t *testing.T) string {
b.WriteString("echo '[download]' 1>&2\n")
b.WriteString("echo 'DATA'\n")
if err := os.WriteFile(path, []byte(b.String()), 0o755); err != nil {
if err := os.WriteFile(path, []byte(b.String()), 0o600); err != nil {
t.Fatalf("failed to write fake yt-dlp: %v", err)
}
return path
@@ -98,7 +98,7 @@ func TestRunDownload_FileMethod_OmitsFormatSort(t *testing.T) {
// Give the logging script a moment to flush in slower environments.
time.Sleep(20 * time.Millisecond)
data, err := os.ReadFile(argsLog)
data, err := os.ReadFile(argsLog) //nolint:gosec // test temp file
if err != nil {
t.Fatalf("reading args log failed: %v", err)
}
@@ -157,7 +157,7 @@ func TestRunDownload_FileMethod_WithFormatSort(t *testing.T) {
time.Sleep(20 * time.Millisecond)
data, err := os.ReadFile(argsLog)
data, err := os.ReadFile(argsLog) //nolint:gosec // test temp file
if err != nil {
t.Fatalf("reading args log failed: %v", err)
}