johanels/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-12-11 22:14:05 +01:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

✨ Add strong file schema validation after file data migration

Browse Source
This commit is contained in:
Andrey Antukh
2025-10-13 16:43:57 +02:00
parent c9761684c1
commit 95df07a364
3 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
common/src/app/common/files/migrations.cljc
View File

@@ -75,7 +75,9 @@
data data
(-> data (-> data
(assoc :id id) (assoc :id id)
(dissoc :version :libs))] (dissoc :version)
(dissoc :libs)
(ctf/check-file-data))]
(-> file (-> file
(assoc :data data) (assoc :data data)

4
common/src/app/common/types/file.cljc
View File

@@ -114,10 +114,10 @@
(sm/register! ::typographies schema:typographies) (sm/register! ::typographies schema:typographies)
(def check-file (def check-file
(sm/check-fn schema:file :hint "check error on validating file")) (sm/check-fn schema:file :hint "invalid file"))
(def check-file-data (def check-file-data
(sm/check-fn schema:data)) (sm/check-fn schema:data :hint "invalid file data"))
(def check-file-media (def check-file-media
(sm/check-fn schema:media)) (sm/check-fn schema:media))

4
common/test/common_tests/files_migrations_test.cljc
View File

@@ -9,6 +9,7 @@
[app.common.data :as d] [app.common.data :as d]
[app.common.files.migrations :as cfm] [app.common.files.migrations :as cfm]
[app.common.pprint :as pp] [app.common.pprint :as pp]
[app.common.types.file :as ctf]
[clojure.test :as t])) [clojure.test :as t]))
(defmethod cfm/migrate-data "test/1" [data _] (update data :sum inc)) (defmethod cfm/migrate-data "test/1" [data _] (update data :sum inc))
@@ -17,7 +18,8 @@
(t/deftest generic-migration-subsystem-1 (t/deftest generic-migration-subsystem-1
(let [migrations (into (d/ordered-set) ["test/1" "test/2" "test/3"])] (let [migrations (into (d/ordered-set) ["test/1" "test/2" "test/3"])]
(with-redefs [cfm/available-migrations migrations] (with-redefs [cfm/available-migrations migrations
ctf/check-file-data identity]
(let [file {:data {:sum 1} (let [file {:data {:sum 1}
:id 1 :id 1
:migrations (d/ordered-set "test/1")} :migrations (d/ordered-set "test/1")}