johanels/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-12-11 22:14:05 +01:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

🐛 Fix font-family being split up when restoring from backup value

Browse Source
This commit is contained in:
Florian Schroedl
2025-09-11 10:00:25 +02:00
committed by Andrés Moya
parent 2d68f4dfd3
commit 61cfe2d142
2 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
frontend/playwright/ui/specs/tokens.spec.js
View File

@@ -960,6 +960,12 @@ test.describe("Tokens: Themes modal", () => {
name: /save/i, name: /save/i,
}); });
// Fill font-family to verify to verify that input value doesn't get split into list of characters
const fontFamilyField = tokensUpdateCreateModal
.getByLabel("Font family")
.first();
await fontFamilyField.fill("OneWord");
// Invalidate incorrect values for font size // Invalidate incorrect values for font size
const fontSizeField = tokensUpdateCreateModal.getByLabel(/Font Size/i); const fontSizeField = tokensUpdateCreateModal.getByLabel(/Font Size/i);
await fontSizeField.fill("invalid"); await fontSizeField.fill("invalid");
@@ -975,9 +981,6 @@ test.describe("Tokens: Themes modal", () => {
// Fill in values for all fields and verify they persist when switching tabs // Fill in values for all fields and verify they persist when switching tabs
await fontSizeField.fill("16"); await fontSizeField.fill("16");
const fontFamilyField = tokensUpdateCreateModal
.getByLabel(/Font Family/i)
.first();
const fontWeightField = const fontWeightField =
tokensUpdateCreateModal.getByLabel(/Font Weight/i); tokensUpdateCreateModal.getByLabel(/Font Weight/i);
const letterSpacingField = const letterSpacingField =

6
frontend/src/app/main/ui/workspace/tokens/management/create/form.cljs
View File

@@ -1024,7 +1024,11 @@ custom-input-token-value-props: Custom props passed to the custom-input-token-va
(fn [e] (fn [e]
(if reference-tab-active? (if reference-tab-active?
(swap! backup-state-ref assoc :reference (dom/get-target-val e)) (swap! backup-state-ref assoc :reference (dom/get-target-val e))
(swap! backup-state-ref assoc-in [:composite (obj/get e "tokenType")] (dom/get-target-val e))) (let [token-type (obj/get e "tokenType")
token-value (dom/get-target-val e)
token-value (cond-> token-value
(= :font-family token-type) (ctt/split-font-family))]
(swap! backup-state-ref assoc-in [:composite token-type] token-value)))
(on-update-value e))) (on-update-value e)))
input-props (mf/spread-props props {:default-value default-value input-props (mf/spread-props props {:default-value default-value