From 2eed7444b74cce1df7fd542c25e4bca8d1d52ad2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9s=20Moya?= <andres.moya@kaleidos.net>
Date: Tue, 16 Sep 2025 15:07:38 +0200
Subject: [PATCH] :wrench: Add migration to automatically fix validation errors

---
 common/src/app/common/files/migrations.cljc | 19 ++++++++++++-
 common/src/app/common/files/validate.cljc   | 30 ++++++++++-----------
 2 files changed, 33 insertions(+), 16 deletions(-)

diff --git a/common/src/app/common/files/migrations.cljc b/common/src/app/common/files/migrations.cljc
index 1e1950f85e..2284f95e45 100644
--- a/common/src/app/common/files/migrations.cljc
+++ b/common/src/app/common/files/migrations.cljc
@@ -1568,6 +1568,22 @@
     (-> data
         (update :pages-index d/update-vals update-page))))
 
+(defmethod migrate-data "0011-fix-invalid-text-touched-flags"
+  [data _]
+  (letfn [(fix-shape [shape]
+            (let [touched-groups (ctk/normal-touched-groups shape)
+                  content-touched? (touched-groups :content-group)
+                  text-touched?    (or (touched-groups :text-content-text)
+                                       (touched-groups :text-content-attribute)
+                                       (touched-groups :text-content-structure))]
+              (if (and text-touched? (not content-touched?))
+                (update shape :touched ctk/set-touched-group :content-group)
+                shape)))
+
+          (update-page [page]
+            (d/update-when page :objects d/update-vals fix-shape))]
+    (-> data
+        (update :pages-index d/update-vals update-page))))
 
 (def available-migrations
   (into (d/ordered-set)
@@ -1635,4 +1651,5 @@
          "0008-fix-library-colors-v4"
          "0009-clean-library-colors"
          "0009-add-partial-text-touched-flags"
-         "0010-fix-swap-slots-pointing-non-existent-shapes"]))
+         "0010-fix-swap-slots-pointing-non-existent-shapes"
+         "0011-fix-invalid-text-touched-flags"]))
diff --git a/common/src/app/common/files/validate.cljc b/common/src/app/common/files/validate.cljc
index a2e6bbe832..02887b5f5e 100644
--- a/common/src/app/common/files/validate.cljc
+++ b/common/src/app/common/files/validate.cljc
@@ -329,19 +329,19 @@
                   "This shape has children with the same swap slot"
                   shape file page)))
 
-#_(defn- check-valid-touched
-    "Validate that the text touched flags are coherent."
-    [shape file page]
-    (let [touched-groups (ctk/normal-touched-groups shape)
-          content-touched? (touched-groups :content-group)
-          text-touched?    (or (touched-groups :text-content-text)
-                               (touched-groups :text-content-attribute)
-                               (touched-groups :text-content-structure))]
+(defn- check-valid-touched
+  "Validate that the text touched flags are coherent."
+  [shape file page]
+  (let [touched-groups (ctk/normal-touched-groups shape)
+        content-touched? (touched-groups :content-group)
+        text-touched?    (or (touched-groups :text-content-text)
+                             (touched-groups :text-content-attribute)
+                             (touched-groups :text-content-structure))]
     ;; For now we only check this combination, that has been reported in some bugs
-      (when (and text-touched? (not content-touched?))
-        (report-error :invalid-text-touched
-                      "This thape has text type touched but not content touched"
-                      shape file page))))
+    (when (and text-touched? (not content-touched?))
+      (report-error :invalid-text-touched
+                    "This thape has text type touched but not content touched"
+                    shape file page))))
 
 (defn- check-shape-main-root-top
   "Root shape of a top main instance:
@@ -384,7 +384,7 @@
     (check-component-ref shape file page libraries)
     (check-empty-swap-slot shape file page)
     (check-duplicate-swap-slot shape file page)
-    #_(check-valid-touched shape file page)  ;; TODO: activate this again after we add a migration that repairs files automatically
+    (check-valid-touched shape file page)
     (run! #(check-shape % file page libraries :context :copy-top :library-exists library-exists) (:shapes shape))))
 
 (defn- check-shape-copy-root-nested
@@ -395,7 +395,7 @@
   [shape file page libraries library-exists]
   (check-component-not-main-head shape file page libraries)
   (check-component-not-root shape file page)
-  #_(check-valid-touched shape file page)
+  (check-valid-touched shape file page)
   ;; We can have situations where the nested copy and the ancestor copy come from different libraries and some of them have been dettached
   ;; so we only validate the shape-ref if the ancestor is from a valid library
   (when library-exists
@@ -418,7 +418,7 @@
   (check-component-not-root shape file page)
   (check-component-ref shape file page libraries)
   (check-empty-swap-slot shape file page)
-  #_(check-valid-touched shape file page)
+  (check-valid-touched shape file page)
   (run! #(check-shape % file page libraries :context :copy-any) (:shapes shape)))
 
 (defn- check-shape-not-component