Merge pull request #7729 from penpot/ladybenko-12514-fix-font-variants

🐛 Fix downloading wrong font variant
This commit is contained in:
Elena Torró
2025-11-12 15:30:08 +01:00
committed by GitHub
16 changed files with 86 additions and 60 deletions

View File

@@ -23,11 +23,18 @@ export class BasePage {
);
}
static async mockFileMediaAsset(page, assetId, assetFilename, options) {
static async mockFileMediaAsset(
page,
assetId,
assetFilename,
assetThumbnailFilename,
options,
) {
const ids = Array.isArray(assetId) ? assetId : [assetId];
for (const id of ids) {
const url = `**/assets/by-file-media-id/${id}`;
const thumbnailUrl = `${url}/thumbnail`;
await page.route(url, (route) =>
route.fulfill({
@@ -36,6 +43,16 @@ export class BasePage {
...options,
}),
);
if (assetThumbnailFilename) {
await page.route(thumbnailUrl, (route) =>
route.fulfill({
path: `playwright/data/${assetThumbnailFilename}`,
status: 200,
...options,
}),
);
}
}
}
@@ -55,22 +72,6 @@ export class BasePage {
}
}
static async mockFileMediaAsset(page, assetId, assetFilename, options) {
const ids = Array.isArray(assetId) ? assetId : [assetId];
for (const id of ids) {
const url = `**/assets/by-file-media-id/${id}`;
await page.route(url, (route) =>
route.fulfill({
path: `playwright/data/${assetFilename}`,
status: 200,
...options,
}),
);
}
}
static async mockConfigFlags(page, flags) {
const url = "**/js/config.js?ts=*";
return await page.route(url, (route) =>
@@ -100,11 +101,17 @@ export class BasePage {
return BasePage.mockConfigFlags(this.page, flags);
}
async mockFileMediaAsset(assetId, assetFilename, options) {
async mockFileMediaAsset(
assetId,
assetFilename,
assetThumbnailFilename,
options,
) {
return BasePage.mockFileMediaAsset(
this.page,
assetId,
assetFilename,
assetThumbnailFilename,
options,
);
}