johanels/penpot
1
0
Fork 0
mirror of https://github.com/penpot/penpot.git synced 2025-12-11 22:14:05 +01:00
Code Issues Actions 9 Packages Projects Releases Wiki Activity

🐛 Do not report explicit user reject as error on oidc auth process

Browse Source
This commit is contained in:
Andrey Antukh
2024-07-09 13:57:48 +02:00
parent fc1495fdd1
commit 0ae8cb4979
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
backend/src/app/auth/oidc.clj
View File

@@ -420,12 +420,6 @@
(defn- get-info (defn- get-info
[{:keys [::provider ::setup/props] :as cfg} {:keys [params] :as request}] [{:keys [::provider ::setup/props] :as cfg} {:keys [params] :as request}]
(when-let [error (get params :error)]
(ex/raise :type :internal
:code :error-on-retrieving-code
:error-id error
:error-desc (get params :error_description)))
(let [state (get params :state) (let [state (get params :state)
code (get params :code) code (get params :code)
state (tokens/verify props {:token state :iss :oauth}) state (tokens/verify props {:token state :iss :oauth})
@@ -609,9 +603,11 @@
(defn- callback-handler (defn- callback-handler
[cfg request] [cfg request]
(try (try
(let [info (get-info cfg request) (if-let [error (dm/get-in request [:params :error])]
profile (get-profile cfg info)] (redirect-with-error "unable-to-auth" error)
(process-callback cfg request info profile)) (let [info (get-info cfg request)
profile (get-profile cfg info)]
(process-callback cfg request info profile)))
(catch Throwable cause (catch Throwable cause
(l/err :hint "error on oauth process" :cause cause) (l/err :hint "error on oauth process" :cause cause)
(redirect-with-error "unable-to-auth" (ex-message cause))))) (redirect-with-error "unable-to-auth" (ex-message cause)))))