johanels/akvorado
1
0
Fork 0
mirror of https://github.com/akvorado/akvorado.git synced 2025-12-12 06:24:10 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

common/reporter: simplify interface for collecting metrics

Browse Source 
Remove unused methods and always collect scoped metrics. As a
side-effect, BioRIS gRPC metrics are now correctly scoped.
This commit is contained in:
Vincent Bernat
2025-08-27 07:32:24 +02:00
parent 3affecc309
commit fa11e7de6d
9 changed files with 19 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
common/reporter/metrics/root.go
View File

@@ -100,25 +100,9 @@ func (m *Metrics) Factory(skipCallstack int) *Factory {
return &factory
}
// Desc allocates and initializes and new metric description. Like for
// factory, names are prefixed with the module name. Unlike factory,
// there is no cache.
func (m *Metrics) Desc(skipCallstack int, name, help string, variableLabels []string) *prometheus.Desc {
callStack := stack.Callers()
call := callStack[1+skipCallstack] // Trial and error, there is a test to check it works
prefix := getPrefix(call.FunctionName())
name = fmt.Sprintf("%s%s", prefix, name)
return prometheus.NewDesc(name, help, variableLabels, nil)
}
// Collector register a custom collector.
func (m *Metrics) Collector(c prometheus.Collector) {
m.registry.MustRegister(c)
}
// CollectorForCurrentModule register a custom collector and prefix
// RegisterCollector register a custom collector and prefix
// everything with the module name.
func (m *Metrics) CollectorForCurrentModule(skipCallStack int, c prometheus.Collector) {
func (m *Metrics) RegisterCollector(skipCallStack int, c prometheus.Collector) {
callStack := stack.Callers()
call := callStack[1+skipCallStack] // Should be the same as above !
prefix := getPrefix(call.FunctionName())