From e4b30ecea798471f7ccce44a85f576d0e35a3f9c Mon Sep 17 00:00:00 2001 From: Vincent Bernat Date: Wed, 1 Feb 2023 12:03:58 +0100 Subject: [PATCH] common/helpers: fix race condition when checking last access on expire --- common/helpers/cache/cache.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/common/helpers/cache/cache.go b/common/helpers/cache/cache.go index d8f975fb..8501014a 100644 --- a/common/helpers/cache/cache.go +++ b/common/helpers/cache/cache.go @@ -105,7 +105,8 @@ func (c *Cache[K, V]) DeleteLastAccessedBefore(before time.Time) int { c.mu.Lock() defer c.mu.Unlock() for k, v := range c.items { - if v.LastAccessed < before.Unix() { + last := atomic.LoadInt64(&v.LastAccessed) + if last < before.Unix() { delete(c.items, k) count++ }