johanels/akvorado
1
0
Fork 0
mirror of https://github.com/akvorado/akvorado.git synced 2025-12-11 22:14:02 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

tests: replace godebug by go-cmp for structure diffs

Browse Source 
go-cmp is stricter and allow to catch more problems. Moreover, the
output is a bit nicer.
This commit is contained in:
Vincent Bernat
2025-08-23 08:28:38 +02:00
parent 1a09ba9e7c
commit e2f1df9add
45 changed files with 852 additions and 710 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
common/helpers/tests_http.go
View File

@@ -24,12 +24,12 @@ type HTTPEndpointCases []struct {
Method string
URL string
Header http.Header
JSONInput any
JSONInput gin.H
ContentType string
StatusCode int
FirstLines []string
JSONOutput any
JSONOutput gin.H
}
// TestHTTPEndpoints test a few HTTP endpoints
@@ -108,6 +108,9 @@ func TestHTTPEndpoints(t *testing.T, serverAddr net.Addr, cases HTTPEndpointCase
for reader.Scan() && len(got) < len(tc.FirstLines) {
got = append(got, reader.Text())
}
if tc.FirstLines == nil {
tc.FirstLines = []string{}
}
if diff := Diff(got, tc.FirstLines); diff != "" {
t.Errorf("%s%s %s (-got, +want):\n%s", tc.Pos, tc.Method, tc.URL, diff)
}
@@ -117,7 +120,18 @@ func TestHTTPEndpoints(t *testing.T, serverAddr net.Addr, cases HTTPEndpointCase
if err := decoder.Decode(&got); err != nil {
t.Fatalf("%s%s %s:\n%+v", tc.Pos, tc.Method, tc.URL, err)
}
if diff := Diff(got, tc.JSONOutput); diff != "" {
// Encode/decode expected to compare JSON stuff
var expected gin.H
expectedBytes, err := json.Marshal(tc.JSONOutput)
if err != nil {
t.Fatalf("json.Marshal() error:\n%+v", err)
}
if err := json.Unmarshal(expectedBytes, &expected); err != nil {
t.Fatalf("json.Unmarshal() error:\n%+v", err)
}
if diff := Diff(got, expected); diff != "" {
t.Fatalf("%s%s %s (-got, +want):\n%s", tc.Pos, tc.Method, tc.URL, diff)
}
}