chore: fix some small issues detected by golangci-lint

But not using it as some linters are either plain incorrect (the one
suggesting to not use nil for `c.t.Context()`) or just
debatable (checking for err value is a good practice, but there are
good reasons to opt out in some cases).
This commit is contained in:
Vincent Bernat
2022-08-10 17:44:32 +02:00
parent 17eb5529cf
commit 78fb01c223
17 changed files with 36 additions and 78 deletions

View File

@@ -73,10 +73,8 @@ func TestHealthcheckCancelContext(t *testing.T) {
return reporter.HealthcheckResult{reporter.HealthcheckOK, "all well"}
})
r.RegisterHealthcheck("hc2", func(ctx context.Context) reporter.HealthcheckResult {
select {
case <-ctx.Done():
return reporter.HealthcheckResult{reporter.HealthcheckError, "I am late, sorry"}
}
<-ctx.Done()
return reporter.HealthcheckResult{reporter.HealthcheckError, "I am late, sorry"}
})
ctx, cancel := context.WithCancel(context.Background())
go func() {