johanels/akvorado
1
0
Fork 0
mirror of https://github.com/akvorado/akvorado.git synced 2025-12-11 22:14:02 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

orchestrator/kafka: alter topic configuration only when needed (config diff) and allow strict policy disabling

Browse Source
This commit is contained in:
Itah
2023-12-28 14:24:03 +04:00
committed by Vincent Bernat
parent 83f9e1d04c
commit 0e435165ff
5 changed files with 77 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
orchestrator/kafka/root.go
View File

@@ -105,12 +105,14 @@ func (c *Component) Start() error {
l.Warn().Msgf("mismatch for replication factor: got %d, want %d",
topic.ReplicationFactor, c.config.TopicConfiguration.ReplicationFactor)
}
if err := admin.AlterConfig(sarama.TopicResource, c.kafkaTopic, c.config.TopicConfiguration.ConfigEntries, false); err != nil {
l.Err(err).Msg("unable to set topic configuration")
return fmt.Errorf("unable to set topic configuration for %q: %w",
c.kafkaTopic, err)
if ShouldAlterConfiguration(c.config.TopicConfiguration.ConfigEntries, topic.ConfigEntries, c.config.TopicConfiguration.ConfigEntriesStrictSync) {
if err := admin.AlterConfig(sarama.TopicResource, c.kafkaTopic, c.config.TopicConfiguration.ConfigEntries, false); err != nil {
l.Err(err).Msg("unable to set topic configuration")
return fmt.Errorf("unable to set topic configuration for %q: %w",
c.kafkaTopic, err)
}
l.Info().Msg("topic updated")
}
l.Info().Msg("topic updated")
}
return nil
}