From 0db8f43b10630566a074c8895cba23d4d94e74ac Mon Sep 17 00:00:00 2001 From: Vincent Bernat Date: Tue, 16 Sep 2025 21:42:13 +0200 Subject: [PATCH] common/httpserver: do not connect to Redis before starting component We need to be able to dump the configuration without redis being present. --- common/httpserver/root.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/common/httpserver/root.go b/common/httpserver/root.go index debc21e5..40dd4cd0 100644 --- a/common/httpserver/root.go +++ b/common/httpserver/root.go @@ -47,7 +47,6 @@ type Dependencies struct { // New creates a new HTTP component. func New(r *reporter.Reporter, configuration Configuration, dependencies Dependencies) (*Component, error) { - var err error c := Component{ r: r, d: &dependencies, @@ -58,10 +57,6 @@ func New(r *reporter.Reporter, configuration Configuration, dependencies Depende } c.initMetrics() c.d.Daemon.Track(&c.t, "common/http") - c.cacheStore, err = configuration.Cache.Config.New() - if err != nil { - return nil, err - } c.GinRouter.Use(gin.Recovery()) c.AddHandler("/api/", c.GinRouter) if configuration.Profiler { @@ -109,6 +104,13 @@ func (c *Component) Start() error { if c.config.Listen == "" { return nil } + + c.r.Info().Msg("starting HTTP component") + var err error + c.cacheStore, err = c.config.Cache.Config.New() + if err != nil { + return err + } server := &http.Server{Handler: c.mux} // Most of the time, if we have an error, it's here!