johanels/akvorado
1
0
Fork 0
mirror of https://github.com/akvorado/akvorado.git synced 2025-12-12 06:24:10 +01:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

outlet/kafka: fix race in tests
Some checks failed
CI / 🤖 Check dependabot status (push) Has been cancelled
Details
CI / 🐧 Test on Linux (${{ github.ref_type == 'tag' }}, misc) (push) Has been cancelled
Details
CI / 🐧 Test on Linux (coverage) (push) Has been cancelled
Details
CI / 🐧 Test on Linux (regular) (push) Has been cancelled
Details
CI / ❄️ Build on Nix (push) Has been cancelled
Details
CI / 🍏 Build and test on macOS (push) Has been cancelled
Details
CI / 🧪 End-to-end testing (push) Has been cancelled
Details
CI / 🔍 Upload code coverage (push) Has been cancelled
Details
CI / 🔬 Test only Go (push) Has been cancelled
Details
CI / 🔬 Test only JS (${{ needs.dependabot.outputs.package-ecosystem }}, 20) (push) Has been cancelled
Details
CI / 🔬 Test only JS (${{ needs.dependabot.outputs.package-ecosystem }}, 22) (push) Has been cancelled
Details
CI / 🔬 Test only JS (${{ needs.dependabot.outputs.package-ecosystem }}, 24) (push) Has been cancelled
Details
CI / ⚖️ Check licenses (push) Has been cancelled
Details
CI / 🐋 Build Docker images (push) Has been cancelled
Details
CI / 🐋 Tag Docker images (push) Has been cancelled
Details
CI / 🚀 Publish release (push) Has been cancelled
Details

Browse Source 
This was introduced in the fix introduced in 7f5950f89c.
This commit is contained in:
Vincent Bernat
2025-11-12 23:53:17 +01:00
parent beb9a3f0ba
commit 001fc71bb4
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
outlet/kafka/root_test.go
View File

@@ -5,6 +5,7 @@ package kafka
import ( import (
"context" "context"
"sync/atomic"
"testing" "testing"
"time" "time"
@@ -17,7 +18,7 @@ func TestMock(t *testing.T) {
got := []string{} got := []string{}
expected := []string{"hello1", "hello2", "hello3"} expected := []string{"hello1", "hello2", "hello3"}
gotAll := make(chan bool) gotAll := make(chan bool)
shutdownCalled := false var shutdownCalled atomic.Bool
callback := func(_ context.Context, message []byte) error { callback := func(_ context.Context, message []byte) error {
got = append(got, string(message)) got = append(got, string(message))
if len(got) == len(expected) { if len(got) == len(expected) {
@@ -27,7 +28,7 @@ func TestMock(t *testing.T) {
} }
c.StartWorkers( c.StartWorkers(
func(int, chan<- ScaleRequest) (ReceiveFunc, ShutdownFunc) { func(int, chan<- ScaleRequest) (ReceiveFunc, ShutdownFunc) {
return callback, func() { shutdownCalled = true } return callback, func() { shutdownCalled.Store(true) }
}, },
) )
@@ -47,7 +48,7 @@ func TestMock(t *testing.T) {
c.Stop() c.Stop()
time.Sleep(10 * time.Millisecond) time.Sleep(10 * time.Millisecond)
if !shutdownCalled { if !shutdownCalled.Load() {
t.Error("Stop() should have triggered shutdown function") t.Error("Stop() should have triggered shutdown function")
} }
} }